-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unboxing the embedded cluster #4951
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaawong
force-pushed
the
miawong/unboxing-the-embedded-cluster
branch
from
October 15, 2024 15:24
5bc2259
to
fd139e6
Compare
sgalsaleh
reviewed
Oct 17, 2024
@@ -55,6 +58,7 @@ function PreflightResultPage(props: Props) { | |||
// TODO: remove this once everything is using react-query | |||
// componentWilUnmount | |||
useEffect(() => { | |||
props.setCurrentStep(3); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes it is. it sets the sidebar step.
sgalsaleh
reviewed
Oct 17, 2024
miaawong
force-pushed
the
miawong/unboxing-the-embedded-cluster
branch
from
October 22, 2024 14:02
f8e4eca
to
17fd68c
Compare
sgalsaleh
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR creates a new unboxing experience for embedded cluster that guides the users on how to setup and deploy the application.
https://app.shortcut.com/replicated/story/108964/redesign-implementation-for-the-tls-warning-page-unboxing-embedded-cluster
https://www.loom.com/share/7c1ae5ff58084674b580541e42c88662
[sc-108964]
Which issue(s) this PR fixes:
Does this PR require a test?
Does this PR require a release note?
Does this PR require documentation?